- From: Anne van Kesteren <notifications@github.com>
- Date: Wed, 06 Apr 2022 01:46:02 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1417/review/933106783@github.com>
@annevk commented on this pull request. I have some nits on the wording and whether this should be should or must, but otherwise looks okay to me. > + <li><p>If <var>connection</var> is an HTTP/3 connection, <var>timingInfo</var>'s + <a for="connection timing info">connection start time</a> and <var>timingInfo</var>'s + <a for="connection timing info">secure connection start time</a> should be equal, as in HTTP/3 + the handshake process is performed as part of the initial connection setup. [[!HTTP3]] It's not clear to me why this is a "should" and not a "must". I also separated the justification as we don't typically do those as part of a requirement. We already expose the connection type through ALPN negotiated protocol so that's not a new concern. ```suggestion <li><p>If <var>connection</var> is an HTTP/3 connection, <var>timingInfo</var>'s <a for="connection timing info">connection start time</a> and <var>timingInfo</var>'s <a for="connection timing info">secure connection start time</a> must be equal. (In HTTP/3 the secure transport handshake process is performed as part of the initial connection setup.) [[!HTTP3]] ``` -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1417#pullrequestreview-933106783 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1417/review/933106783@github.com>
Received on Wednesday, 6 April 2022 08:46:14 UTC