- From: Noam Rosenthal <notifications@github.com>
- Date: Thu, 30 Sep 2021 03:00:45 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 30 September 2021 10:00:58 UTC
> Looking at this again I think I missed something initially and this could be a lot simpler. All these network errors end up in "fetch finale" and it seems that at that point we could initialize them. Yes, that would simplify things! > That leaves "finalize response". I suppose that for some network errors (in particular CORS) there could be a successful body stream so this would come later. For others that might not happen. Either way, we probably want to report them as soon as possible (i.e., as part of "fetch finale") to avoid leaking timing information. (Which also means "finalize response" (or its callers) has to filter out network errors or some such.) > > Does that make sense or am I missing something here? We're already reporting them in the fetch finale, by calling `process response done` which would schedule the caller to run some steps, one of which would be to report timing for the response with the correct `initiatorType`, and allowing the caller to decide the order of events / reporting. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1311#issuecomment-931176137
Received on Thursday, 30 September 2021 10:00:58 UTC