Re: [whatwg/fetch] Allow range header without preflight (#1312)

@annevk commented on this pull request.

Thanks for the analysis! Modulo some final nits this looks good to me now. I wonder if @mikewest, @yutakahirano, and @youennf can help out with additional security review.

(This also ends up fixing #1265 now. It seems okay to include the fix for that here, as long as we indicate it in the final commit message.)

> + are in the range U+0030 (0) to U+0039 (9), inclusive, from <var>data</var> given
+ <var>position</var>.

```suggestion
 are <a>ASCII digits</a>, from <var>data</var> given <var>position</var>.
```

> + are in the range U+0030 (0) to U+0039 (9), inclusive, from <var>data</var> given
+ <var>position</var>.

```suggestion
 are <a>ASCII digits</a>, from <var>data</var> given <var>position</var>.
```

> + pointing at the 6th <a>code point</a> of <var>data</var>.
+
+ <li><p>Let <var>rangeStart</var> be the result of <a>collecting a sequence of code points</a> that
+ are in the range U+0030 (0) to U+0039 (9), inclusive, from <var>data</var> given
+ <var>position</var>.
+
+ <li><p>If the <a>code point</a> at <var>position</var> within <var>data</var> is not U+002D (-),
+ then return false.
+
+ <li><p>Advance <var>position</var> by 1.
+
+ <li><p>Let <var>rangeEnd</var> be the result of <a>collecting a sequence of code points</a> that
+ are in the range U+0030 (0) to U+0039 (9), inclusive, from <var>data</var> given
+ <var>position</var>.
+
+ <li><p>If <var>position</var> is not past the end of <var>data</var>, return false.

```suggestion
 <li><p>If <var>position</var> is not past the end of <var>data</var>, then return false.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1312#pullrequestreview-766303345