Re: [whatwg/fetch] Expose a mechanism for hiding internal timing info (#1309)

@annevk commented on this pull request.

Looks good modulo nits. If we end up creating fetch timing info instances in more places, we should perhaps consider an abstraction for that too. In the two places where we do that today in Fetch we always set start time and post-redirect start time to the same value and adjust nothing else.

> @@ -231,6 +231,12 @@ following <a for=struct>items</a>: [[RESOURCE-TIMING]] [[NAVIGATION-TIMING]]
  <dd>Null or a <a for=/>connection timing info</a>.
 </dl>
 
+<p>To <dfn export lt="create an opaque timing info|creating an opaque timing info">create an
+opaque timing info</dfn>, given a <a for=/>fetch timing info</a> <var>timingInfo</var>,
+ create a new <a for=/>fetch timing info</a> whose <a for="fetch timing info">start time</a> and

```suggestion
 return a new <a for=/>fetch timing info</a> whose <a for="fetch timing info">start time</a> and
```

> @@ -231,6 +231,12 @@ following <a for=struct>items</a>: [[RESOURCE-TIMING]] [[NAVIGATION-TIMING]]
  <dd>Null or a <a for=/>connection timing info</a>.
 </dl>
 
+<p>To <dfn export lt="create an opaque timing info|creating an opaque timing info">create an
+opaque timing info</dfn>, given a <a for=/>fetch timing info</a> <var>timingInfo</var>,
+ create a new <a for=/>fetch timing info</a> whose <a for="fetch timing info">start time</a> and
+ <a for="fetch timing info">post-redirect start time</a> are <var>timingInfo</var>'s
+ <a for="fetch timing info">start time</a>.

Indentation is wrong in this block. Also has newlines inside phrasing elements.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1309#pullrequestreview-765362420