- From: Marcos Cáceres <notifications@github.com>
- Date: Sun, 26 Sep 2021 23:38:03 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 27 September 2021 06:38:16 UTC
@marcoscaceres commented on this pull request. > + </p> + <ol class="algorithm"> + <li>Set |manifest|["id"] to |manifest|["start_url"]. + </li> + <li>If the type of |json|["id"] is not [=string=], return. + </li> + <li>If |json|["id"] is the empty string, return. + </li> + <li>Let |base origin| be |manifest|["start_url"]'s [=url/origin=].</li> + <li>Let |id:URL| be the result of [=URL Parser|parsing=] |json|["id"] with |base origin| as the base URL. + </li> + <li>If |id| is failure, return. + </li> + <li>If |id| is not [=same origin=] as |manifest|["start_url"], return. + </li> + <li>Otherwise, set |manifest|["id"] to |id|.</li> Thanks @philloooo. Appreciate you gathering the additional input from @dmurph. I've updated the Gecko implementation to match. I know it took us a a while, but really happy with were we are ending up with this 🥰 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/988#discussion_r716396802
Received on Monday, 27 September 2021 06:38:16 UTC