- From: Yajing Tang <notifications@github.com>
- Date: Thu, 23 Sep 2021 09:36:36 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 23 September 2021 16:36:49 UTC
@philloooo commented on this pull request.
> + </p>
+ <ol class="algorithm">
+ <li>Set |manifest|["id"] to |manifest|["start_url"].
+ </li>
+ <li>If the type of |json|["id"] is not [=string=], return.
+ </li>
+ <li>If |json|["id"] is the empty string, return.
+ </li>
+ <li>Let |base origin| be |manifest|["start_url"]'s [=url/origin=].</li>
+ <li>Let |id:URL| be the result of [=URL Parser|parsing=] |json|["id"] with |base origin| as the base URL.
+ </li>
+ <li>If |id| is failure, return.
+ </li>
+ <li>If |id| is not [=same origin=] as |manifest|["start_url"], return.
+ </li>
+ <li>Otherwise, set |manifest|["id"] to |id|.</li>
I think as a developer, if I'd want to change the start_url but retaining the same identity, I should specify the id field instead?
```
{
"start_url": "foo.html#here",
}
```
To:
```
{
"start_url": "foo.html#there",
"id": "foo.html#here",
}
```
If we remove the fragment, apps that have fragment in start_url today will get a new id when browser ships this feature.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/988#discussion_r714970309
Received on Thursday, 23 September 2021 16:36:49 UTC