- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 20 Sep 2021 22:33:17 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 21 September 2021 05:33:29 UTC
@marcoscaceres commented on this pull request. > + </p> + <p> + To <dfn>process the `id` member</dfn>, given [=object=] + |json:JSON|, [=ordered map=] |manifest:ordered map|: + </p> + <ol class="algorithm"> + <li>Set |manifest|["id"] to |manifest|["start_url"]. + </li> + <li>If the type of |json|["id"] is not [=string=], return. + </li> + <li>Let |id:URL| be the result of [=URL Parser|parsing=] |json|["id"] + with |manifest|["start_url"]'s origin as the base URL. + </li> + <li>If |id| is failure, return. + </li> + <li>If |id| is not same origin as |manifest|["start_url"], return. ```suggestion <li>If |id| is not [=same origin=] as |manifest|["start_url"], return. ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/988#pullrequestreview-759315868
Received on Tuesday, 21 September 2021 05:33:29 UTC