- From: Arthur Sonzogni <notifications@github.com>
- Date: Mon, 20 Sep 2021 06:38:20 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1229/review/758643595@github.com>
@ArthurSonzogni commented on this pull request. > @@ -1892,6 +1892,24 @@ source of security bugs. Please seek security review for features that deal with <a for="URL serializer"><i>exclude fragment</i></a> set to true. </ol> +<p>To check <dfn export>Cross-Origin-Embedder-Policy allows credentials</dfn>, given a +<a for=/>request</a> <var>request</var>, run theses steps: + +<ol> + <li><p>If <var>request</var>'s <a for=request>mode</a> is not <code>no-cors</code>", return + true.</p> + + <li><p>If <var>request</var>'s <a for=request>client</a> is null, return true.</p> + + <li><p>If <var>request</var>'s <a for=request>client</a>'s <a for="environment settings + object">embedder policy</a> is not + "<code><a for="embedder policy value">credentialless</a></code>", return true.</p> + + <li><p>If <var>request</var>'s <a for=request>origin</a> is <a>same origin</a> with + <var>request</var>'s <a for=request>current URL</a>'s <a for=url>origin</a>, return true.</p> annevk@, I addressed your suggestion. In the latest patchset, we take into account the tainted origin flag. This gives: ![Capture d’écran du 2021-09-20 15-11-03](https://user-images.githubusercontent.com/4759106/134008757-c834ce74-091e-49b4-abde-5dae072efad0.png) Note: Thanks for the link about "Confused deputy problem", however I still don't see there are anything about `COEP:credentialless ` and the threat model about COI & spectre attacks where this really matter. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1229#discussion_r712175485
Received on Monday, 20 September 2021 13:38:33 UTC