- From: Mattias Buelens <notifications@github.com>
- Date: Sat, 04 Sep 2021 16:10:58 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/1164@github.com>
The `QueuingStrategySize` callback type is currently defined as: ``` callback QueuingStrategySize = unrestricted double (optional any chunk); ``` I don't think the `optional` should be there? The stream implementation must always pass a value for `chunk` (although the chunk itself *could* still be `undefined` if the user did `controller.enqueue(undefined)` or `writer.write(undefined)`). <!-- Thank you for contributing to the Streams Standard! Please describe the change you are making and complete the checklist below if your change is not editorial. --> - [ ] At least two implementers are interested (and none opposed): * … * … - [ ] [Tests](https://github.com/web-platform-tests/wpt) are written and can be reviewed and commented upon at: * … - [ ] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed: * Chrome: … * Firefox: … * Safari: … (See [WHATWG Working Mode: Changes](https://whatwg.org/working-mode#changes) for more details.) You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/1164 -- Commit Summary -- * Remove optional from chunk parameter in QueuingStrategySize -- File Changes -- M index.bs (2) M reference-implementation/lib/QueuingStrategy.webidl (2) -- Patch Links -- https://github.com/whatwg/streams/pull/1164.patch https://github.com/whatwg/streams/pull/1164.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1164
Received on Saturday, 4 September 2021 23:11:12 UTC