Re: [whatwg/dom] Add a way to identify Abort errors originating from controllers (Issue #1033)

@kanongil I think @domenic 's point is that the fact a signal originated from a controller is _by design_ opaque to you and cancellation is still going to always be `.name === 'AbortError'`.  So his point is that you _shouldn't_ check this in instrumentation.

I think this is _probably_ fine but the guidance (always throw `signal.reason`) is going to receive _significant pushback_ in Node.js. In particular people were fine with cancellation but the ability to throw any error into the API will likely receive pushback since in Node.js APIs are _very particular_ about what errors they throw and any error changes are semver-major and this means "every API taking a signal can throw anything if you don't control the signal".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/issues/1033#issuecomment-981083644

Received on Sunday, 28 November 2021 13:14:44 UTC