Re: [whatwg/dom] Add a way to identify Abort errors originating from controllers (Issue #1033)

@annevk Thanks - I feel like I need to communicate this. I know you to be very reasonable and I understand it is terrible timing to come here with this problem _after_ the feature landed _and_ James gave an LGTM. I could have raised concerns during that period and missed it - I acknowledge that.

I am not trying to create frustration and I am personally very invested in aiding AbortSignal/AbortController succeed as APIs in many environments. I think this is represented in the (many) APIs we've integrated it into.

I just think I've found an issue with the API change that can cause issues and I feel like I need to make sure we don't create issues for users.

I also acknowledge that it's entirely possible this is just a misunderstanding on my part and that _in practice_ people will only abort with `AbortError`s when signaling abort (and other errors when aborting to not actually abort but to communicate other intent). I am just not convinced changing API guarantees like that is safe.

I will ping the people who have spoken up about this in the past.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/issues/1033#issuecomment-979975510

Received on Friday, 26 November 2021 13:23:35 UTC