Re: [whatwg/fetch] Propagate origin and URL list through the request constructor. (Fixes #1321, #1335) (PR #1345)

@annevk commented on this pull request.



> @@ -6925,6 +6925,9 @@ constructor steps are:
 
    <dt><a for=request>history-navigation flag</a>
    <dd><var>request</var>'s <a for=request>history-navigation flag</a>.
+
+   <dt><a for=request>URL list</a>
+   <dd>A <a for=list>clone</a> of <var>request</var>'s <a for=request>URL list</a>.

Because of this we should remove the setting of request's URL above, right?

>     <li><p>Set <var>request</var>'s <a for=request>referrer</a> to
    "<code>client</code>"
 
    <li><p>Set <var>request</var>'s <a for=request>referrer policy</a> to the empty string.
+
+   <li><p>Set <var>request</var>'s <a for=request>URL list</a> to an empty
+   <a for=/>list</a>.
+
+   <li><p><a for=list>Append</a> <var>request</var>'s <a for=request>URL</a> to
+   <var>request</var>'s <a for=request>URL list</a>.

I'm not sure how this works. Request's URL is a pointer to the first item of request's URL list. It seems you would have to store it in a variable before you reset request's URL list, right? But also, you probably want the last item in request's URL list? I.e., request's current URL.

> @@ -6894,7 +6894,7 @@ constructor steps are:
    <dd><var>request</var>'s <a for=request>priority</a>.
 
    <dt><a for=request>origin</a>
-   <dd>"<code>client</code>".
+   <dd><var>request</var>'s <a for=request>origin</a>.

Please add a note here about how particular the situation is where this is relevant. Probably with `<span class=note>` as we don't seem to have paragraphs here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1345#pullrequestreview-813677222