Re: [whatwg/fetch] Send "null" Origin header on cross-origin .onion requests (PR #1351)

@annevk commented on this pull request.

I guess the only thing remaining here is that if we want to have this check in at least three places, we should probably have an exported "is an onion URL" predicate that takes a URL and returns true or false instead.

> + <li><p>If <var>request</var>'s <a for=request>current URL</a>'s <a for=url>origin</a>'s
+ <a for=origin>host</a> ends with <code>.onion</code> or <code>.onion.</code> [[ONION]], and
+ is not <a>same origin</a> with <var>request</var>'s <a for=request>origin</a>, then set
+ <var>serializedOrigin</var> to `<code>null</code>`.

```suggestion
 <li><p>If <var>request</var>'s <a for=request>current URL</a>'s <a for=url>origin</a>'s
 <a for=origin>host</a> ends with "<code>.onion</code>" or "<code>.onion.</code>", and
 is not <a>same origin</a> with <var>request</var>'s <a for=request>origin</a>, then set
 <var>serializedOrigin</var> to `<code>null</code>`. [[ONION]]
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1351#pullrequestreview-802287343