- From: Darien Maillet Valentine <notifications@github.com>
- Date: Sat, 06 Nov 2021 21:33:37 -0700
- To: whatwg/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Sunday, 7 November 2021 04:33:51 UTC
@bathos commented on this pull request.
> @@ -1694,7 +1694,7 @@ on which they appear. It is language binding specific whether
<pre highlight="webidl">
[Exposed=Window]
interface A {
- const short rambaldi = 47;
+ const uint16 rambaldi = 47;
```suggestion
const int16 rambaldi = 47;
```
This one was signed before. Almost certainly doesn’t matter here for the example, but keeping them the same may help avoid tripping reviewers.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/webidl/pull/1030#pullrequestreview-799496092
Received on Sunday, 7 November 2021 04:33:51 UTC