Re: [whatwg/fetch] Integration with preload (PR #1342)

@annevk commented on this pull request.



> +  <p class="note">This is done in main fetch and not in HTTP-fetch to avoid blocking or race
+  conditions between the networking queue and the document queue. The implication is that if a
+  fetch redirects to a URL that was preloaded, it would not be consumed.</p>

I don't understand this comment. HTTP-redirect fetch invokes main fetch at the end.

>  
- <li><p>If <var>request</var>'s <a>local-URLs-only flag</a> is set and <var>request</var>'s
- <a for=request>current URL</a> is not <a lt="is local">local</a>, then set <var>response</var> to a
- <a>network error</a>.
+ <li><p>If <var>response</var> is null, <var>request</var>'s <a>local-URLs-only flag</a> is set and
+ <var>request</var>'s  <a for=request>current URL</a> is not <a lt="is local">local</a>, then set
+ <var>response</var> to a <a>network error</a>.

This seems to give the idea that a network URL could return something in a local-URLs-only environment, e.g., SVG-as-image. That seems wrong.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1342#pullrequestreview-796494604