- From: yulia <notifications@github.com>
- Date: Tue, 25 May 2021 06:29:58 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 25 May 2021 13:30:11 UTC
@codehag commented on this pull request. > + :: |base|, a [=/URL=] + :: |seen|, a [=/set=] of [=/URLs=] + : Output + :: a boolean + + 1. If |record| is not a [=Cyclic Module Record=], then: + 1. Return false. + 1. If |record|.\[[Async]] is true, then: + 1. Return true. + 1. [=list/For each=] string |requested| of |record|.\[[RequestedModules]]: + 1. Let |url| be the result of [=resolve a module specifier|resolving a module specifier=] given |base| and |requested|. + 1. If |url| is *failure*: + 1. Return false. + 1. If |seen| does not [=set/contain=] |url|, then: + 1. [=set/Append=] |url| to |seen|. + 1. If [=Is Async Module=] for |moduleMap|[|url|]'s [=script/record=], |moduleMap|, |base|, and |seen| is true, then: I think we also want to bring the assertion back: https://github.com/Ms2ger/ServiceWorker/pull/2/commits/6290a2c783987f79eed665db40481815a0e6501c -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1444#discussion_r638788408
Received on Tuesday, 25 May 2021 13:30:11 UTC