- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 18 May 2021 01:12:22 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/url/pull/598/review/661772556@github.com>
@annevk commented on this pull request. Fair enough, looks good modulo nit. > @@ -528,11 +528,17 @@ decisions made, i.e. whether to use the <a>same site</a> or <a>schemelessly same <var>domain</var> and an optional boolean <var>beStrict</var> (default false), runs these steps: <ol> - <li><p>Let <var>result</var> be the result of running <a abstract-op lt=ToASCII>Unicode ToASCII</a> - with <i>domain_name</i> set to <var>domain</var>, <i>UseSTD3ASCIIRules</i> set to - <var>beStrict</var>, <i>CheckHyphens</i> set to false, <i>CheckBidi</i> set to true, - <i>CheckJoiners</i> set to true, <i>Transitional_Processing</i> set to false, - and <i>VerifyDnsLength</i> set to <var>beStrict</var>. + <li> + <p>Let <var>result</var> be the result of running <a abstract-op lt=ToASCII>Unicode ToASCII</a> + with <i>domain_name</i> set to <var>domain</var>, <i>UseSTD3ASCIIRules</i> set to + <var>beStrict</var>, <i>CheckHyphens</i> set to false, <i>CheckBidi</i> set to true, + <i>CheckJoiners</i> set to true, <i>Transitional_Processing</i> set to false, + and <i>VerifyDnsLength</i> set to <var>beStrict</var>. + + <p class=note>If <var>beStrict</var> is false, <var>domain</var> is an <a>ASCII string</a>, and + <a>strictly splitting</a> <var>domain</var> on U+002E (.) does not produce any <a Nit: no newlines inside phrasing elements. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/598#pullrequestreview-661772556
Received on Tuesday, 18 May 2021 08:12:37 UTC