- From: Devin Rousso <notifications@github.com>
- Date: Tue, 04 May 2021 13:26:39 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 4 May 2021 20:26:52 UTC
I don't think we can touch `"theme_color"` as that will break older browsers.
We may want to create a `"theme_colors"` (plural) property that is an array of objects (so that it's extensible if needed in the future) that would take precedence over `"theme_color"`
```
"theme_color": "red",
"theme_colors": [
{ "color": "red" },
{ "color": "darkred", "media": "(prefers-color-scheme: dark)" }
]
```
I don't have a strong preference, but I think using the last item in the list that matches (i.e. last pass) is generally easier to understand/follow (it also more closely matches the way it would be written in CSS).
If this is an approach we like, perhaps we could/should do it for `"background_color"` (i.e. `"background_colors"`) too?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-832220101
Received on Tuesday, 4 May 2021 20:26:52 UTC