Re: [whatwg/streams] Support teeing readable byte streams (#1114)

@domenic commented on this pull request.



> @@ -3205,7 +3442,7 @@ The following abstract operations support the implementation of the
  1. Let |firstDescriptor| be |controller|.[=ReadableByteStreamController/[[pendingPullIntos]]=][0].
  1. If |firstDescriptor|'s [=pull-into descriptor/byte offset=] + |firstDescriptor|' [=pull-into
     descriptor/bytes filled=] is not |view|.\[[ByteOffset]], throw a {{RangeError}} exception.
- 1. If |firstDescriptor|'s [=pull-into descriptor/byte length=] is not |view|.\[[ByteLength]], throw
+ 1. If |firstDescriptor|'s [=pull-into descriptor/byte length=] < |view|.\[[ByteLength]], throw

> Currently, we check the first condition.

Well, _currently_ we kind of check the second one (by checking the view length, which must be >= the buffer length).

I'm thinking now we should pull out this change (to check both 1 + 2 cleanly), including the domintro change you suggest (which is a great idea), into a separate PR. Ideally we'd also add some usage examples for `respondWithNewView()`; I was surprised to not be able to find any in the spec.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1114#discussion_r603504851