Re: [whatwg/fetch] Initial resource timing integration. (#1185)

@noamr commented on this pull request.

Added comments on the TODOs.

> + <a for=/>unsafe shared current time</a> immmediately before starting the handshake process to
+ secure <var>connection</var>. [[!TLS]]
+
+ <li>
+  <p><var>timingInfo</var>'s <a for="connection timing info">alpn negotiated protocol</a> should be
+  the <var>connection</var>'s ALPN Protocol ID, with the following caveats: [[RFC7301]]
+  <!-- TODO Since it's in octets, I guess we have to isomorphic decode it? -->
+
+  <ul>
+   <li><p>When a proxy is configured, if a tunnel connection is established then this must be the
+   ALPN Protocol ID of the tunneled protocol, otherwise it must be the ALPN Protocol ID of the first
+   hop to the proxy.
+
+   <li><p>Octets in the ALPN Protocol ID must not be percent-encoded if they are valid token
+   characters except "%", and when using percent-encoding, uppercase hex digits must be used.
+   <!-- TODO I don't think we have to state this as the network does this. -->

I agree, we can add a reference to https://tools.ietf.org/html/rfc7639#section-2.2 instead

> +  <p><var>timingInfo</var>'s <a for="connection timing info">alpn negotiated protocol</a> should be
+  the <var>connection</var>'s ALPN Protocol ID, with the following caveats: [[RFC7301]]
+  <!-- TODO Since it's in octets, I guess we have to isomorphic decode it? -->
+
+  <ul>
+   <li><p>When a proxy is configured, if a tunnel connection is established then this must be the
+   ALPN Protocol ID of the tunneled protocol, otherwise it must be the ALPN Protocol ID of the first
+   hop to the proxy.
+
+   <li><p>Octets in the ALPN Protocol ID must not be percent-encoded if they are valid token
+   characters except "%", and when using percent-encoding, uppercase hex digits must be used.
+   <!-- TODO I don't think we have to state this as the network does this. -->
+
+   <li><p>Formally registered ALPN Protocol IDs are documented by
+   <a href="https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml#alpn-protocol-ids">IANA</a>.
+   <!-- TODO I'm not sure we need to reference this? -->

I think it's useful, but maybe it can move to a reference inside `Resource Timing` instead

>   <li>
   <p>If <var>request</var>'s <a>service-workers mode</a> is "<code>all</code>", then:
 
   <ol>
    <li><p>Let <var>requestForServiceWorker</var> be a <a for=request>clone</a> of
    <var>request</var>.
 
+   <li><p>Let <var>workerStartTime</var> be the <a for=/>unsafe shared current time</a>.
+   <!-- TODO: can we rename this to service worker start time? -->

Definitely

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1185#pullrequestreview-619343553