Re: [whatwg/xhr] WIP: Resource Timing integration (#319)

@annevk commented on this pull request.

It seems that the way this works out is that there's a report timing object created just before the load event is invoked, which seems good.

> @@ -960,6 +960,11 @@ return <a>this</a>'s <a>cross-origin credentials</a>.
   </ol>
 </ol>
 
+<p id=report-xhr-timing>To <dfn>report timing</dfn> for an {{XMLHttpRequest}} object <var>xhr</var>,
+<a href="https://github.com/whatwg/fetch/pull/1185">finalize and report timing</a> for
+<var>xhr</var>'s <a for=XMLHttpRequest>response</a>, <var>xhr</var>'s <a>relevant global object</a>
+and "xmlhttprequest".

Oxford comma. Strings need to be formatted as `"<code>xmlhttprequest</code>"`.

> @@ -1008,8 +1015,9 @@ return <a>this</a>'s <a>cross-origin credentials</a>.
  <a event><code>abort</code></a>, and "{{AbortError!!exception}}" {{DOMException}}.
 
  <li><p>Otherwise, if <var>xhr</var>'s <a for=XMLHttpRequest>response</a>'s is a
- <a for=/>network error</a>, run the <a>request error steps</a> for <var>xhr</var>,
- <a event><code>error</code></a>, and "{{NetworkError!!exception}}" {{DOMException}}.
+ <a for=/>network error</a>, then run the <a>request error steps</a> for <var>xhr</var>,
+  <a event><code>error</code></a>, and "{{NetworkError!!exception}}" {{DOMException}}.

Indentation is wrong.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/xhr/pull/319#pullrequestreview-617516053