Re: [whatwg/streams] Fix cancelPromise in ReadableStreamTee being resolved twice (#1112) from Mattias Buelens on 2021-03-19 (public-webapps-github@w3.org from March 2021)

From: Mattias Buelens <notifications@github.com>
Date: Fri, 19 Mar 2021 12:10:45 -0700
To: whatwg/streams <streams@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <whatwg/streams/pull/1112/c803051660@github.com>

We're finding all sorts of unexpected errors today! 😁 
```
   transform-streams/patched-global.any.html

  √ TransformStream constructor should not call setters for highWaterMark or size
  × test harness threw unexpected error
    Test named 'TransformStream constructor should not call setters for highWaterMark or size' specified 1 'cleanup' function, and 1 failed.
    null
```
Looks like [this cleanup function](https://github.com/web-platform-tests/wpt/blob/29c9c814031e169d533a7226fa5b48f8573b805a/streams/transform-streams/patched-global.any.js#L18-L21) is failing because we forgot to add `configurable: true` on the patched properties. I'll piggy-back it onto the WPT PR. 😛 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1112#issuecomment-803051660

Received on Friday, 19 March 2021 19:10:58 UTC