- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 18 Mar 2021 01:55:59 -0700
- To: whatwg/xhr <xhr@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 18 March 2021 08:56:11 UTC
@annevk commented on this pull request. > @@ -1008,8 +1015,13 @@ return <a>this</a>'s <a>cross-origin credentials</a>. <a event><code>abort</code></a>, and "{{AbortError!!exception}}" {{DOMException}}. <li><p>Otherwise, if <var>xhr</var>'s <a for=XMLHttpRequest>response</a>'s is a - <a for=/>network error</a>, run the <a>request error steps</a> for <var>xhr</var>, - <a event><code>error</code></a>, and "{{NetworkError!!exception}}" {{DOMException}}. + <a for=/>network error</a>, then perform the following steps: + <ol> + <li><p><a for=/>Report timing</a> for <var>xhr</var>. I think this has to happen in the request error steps, no? Otherwise how would we report for a timeout or abort scenario? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/xhr/pull/319#pullrequestreview-615115556
Received on Thursday, 18 March 2021 08:56:11 UTC