- From: Jake Archibald <notifications@github.com>
- Date: Fri, 12 Mar 2021 05:37:37 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1572/review/610784471@github.com>
@jakearchibald approved this pull request. LGTM with the changes suggested > </tr> <tr> <td><dfn attribute for="ServiceWorkerContainer"><code>onmessageerror</code></dfn></td> - <td>{{messageerror!!event}}</td> + <td>{{ServiceWorkerContainer//messageerror!!event}}</td> ```suggestion <td>{{ServiceWorkerContainer/messageerror!!event}}</td> ``` > @@ -872,6 +872,16 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe <td>{{Event}}</td> <td>The [=ServiceWorkerContainer/service worker client=]'s <a>active service worker</a> changes. (See step 9.2 of the <a>Activate</a> algorithm. The <a>skip waiting flag</a> of a [=/service worker=] causes <a lt="activate">activation</a> of the [=/service worker registration=] to occur while [=/service worker clients=] are <a>using</a> the [=/service worker registration=], {{ServiceWorkerContainer/controller|navigator.serviceWorker.controller}} immediately reflects the <a>active worker</a> as the [=/service worker=] that <a>controls</a> the [=/service worker client=].)</td> </tr> + <tr> + <td><dfn event id="service-worker-container-message-event"><code>message</code></dfn></td> + <td>{{Event}}</td> + <td>The [=ServiceWorkerContainer/service worker client=] receives a message from a [=service worker=]. See {{Client/postMessage(message, options)}}.</td> ```suggestion <td>The [=ServiceWorkerContainer/service worker client=] receives a message from a [=/service worker=]. See {{Client/postMessage(message, options)}}.</td> ``` > @@ -872,6 +872,16 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe <td>{{Event}}</td> <td>The [=ServiceWorkerContainer/service worker client=]'s <a>active service worker</a> changes. (See step 9.2 of the <a>Activate</a> algorithm. The <a>skip waiting flag</a> of a [=/service worker=] causes <a lt="activate">activation</a> of the [=/service worker registration=] to occur while [=/service worker clients=] are <a>using</a> the [=/service worker registration=], {{ServiceWorkerContainer/controller|navigator.serviceWorker.controller}} immediately reflects the <a>active worker</a> as the [=/service worker=] that <a>controls</a> the [=/service worker client=].)</td> </tr> + <tr> + <td><dfn event id="service-worker-container-message-event"><code>message</code></dfn></td> + <td>{{Event}}</td> + <td>The [=ServiceWorkerContainer/service worker client=] receives a message from a [=service worker=]. See {{Client/postMessage(message, options)}}.</td> + </tr> + <tr> + <td><dfn event id="service-worker-container-messageerror-event"><code>messageerror</code></dfn></td> + <td>{{Event}}</td> + <td>The [=ServiceWorkerContainer/service worker client=] is sent a message that cannot be deserialized from a [=service worker=]. See {{Client/postMessage(message, options)}}.</td> ```suggestion <td>The [=ServiceWorkerContainer/service worker client=] is sent a message that cannot be deserialized from a [=/service worker=]. See {{Client/postMessage(message, options)}}.</td> ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1572#pullrequestreview-610784471
Received on Friday, 12 March 2021 13:37:51 UTC