Re: [whatwg/fetch] Initial resource timing integration. (#1185)

@noamr commented on this pull request.



> @@ -1855,6 +1923,9 @@ Unless stated otherwise, it is "<code>default</code>".
 <p class="note">This indicates that the request was intentionally aborted by the developer or
 end-user.
 
+<p>A <a for=/>response</a> can have an associated <a for=/>fetch timing info</a>
+<dfn export for=response id=concept-response-timing-info>timing info</dfn>, initially null.

aye

>  </ol>
 
+<p>To <dfn>handle response end</dfn>, given <a for=/>fetch params</a> <var>fetchParams</var> and

That's a good point. I am not sure where to hook that enqueuing. It should generally happen some time after `response end time` is set, which is somewhat well defined for HTTP but not for workers, as we might return a stream here that is only read later on.

Any thoughts? @yoavweiss 

> @@ -2215,6 +2288,86 @@ clearly stipulates that <a>connections</a> are keyed on
 <!-- See https://github.com/whatwg/fetch/issues/114#issuecomment-143500095 for when we make
      WebSocket saner -->
 
+<p>When <dfn>recording connnection timing info</dfn> given a <var>connection</var>, perform the
+following steps:

It is a step-by-step algorithm of sorts, though some of the steps are defined elsewhere... is there an style example I can copy for how it would look as requirements?

> @@ -3763,11 +3921,41 @@ steps:
 
  <li><p>Wait for either <var>response</var>'s <a for=response>body</a> to be null, or
  <var>response</var>'s <a for=response>body</a>'s <a for=body>stream</a> to be
- <a for=ReadableStream>closed</a> or <a for=ReadableStream>errored</a>, and then set
- <var>request</var>'s <a>done flag</a>.
- <!-- This is really bad and needs to be handled differently at some point. -->
+ <a for=ReadableStream>closed</a> or <a for=ReadableStream>errored</a>, and perform the following steps:
+ <ol>
+  <li><p>Set <var>request</var>'s <a>done flag</a>.
+   <!-- This is really bad and needs to be handled differently at some point. -->
+ </ol>

aye

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1185#discussion_r590446945