Re: [whatwg/fetch] Initial resource timing integration. (#1185)

> It would help a lot if you checked the final diff and read through it at least once to make sure there are no obvious mistakes there. At least I personally tend to spot a lot of mistakes when doing that in my own writing.

Sorry for that. I will double check next time.
> 
> Overall I think this approach looks good. I'm a little worried about it also relying on the "done flag" badness. Perhaps the solution there is to accept that implementations are not full duplex and so once the response stream is closed it's really all over.
> 
> One thing I haven't done in detail is ensuring that the point of capture matches RT and matches implementations. For that it would be helpful to have some pointers to tests. As I also noted I would prefer to not define fields we're unsure of or that can be inferred from other fields.
> 
> (I also do not see transfer size, was that omitted intentionally?)

Yes. `transfer size` will become `encoded body size` + `some constant number`, and that will be done in RT.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1185#issuecomment-792228858

Received on Sunday, 7 March 2021 06:56:59 UTC