Re: [whatwg/fetch] Initial resource timing integration. (#1185)

@yoavweiss commented on this pull request.



> @@ -3348,6 +3396,8 @@ the request.
  <li><p>Run <a>main fetch</a> given <var>fetchParams</var>.
 </ol>
 
+<h3 id="sec-current-time">Current Time</h3>

I don't think this should be an h3 here, but probably something that you should defined in a different section (e.g. in "infrastructure")

> @@ -1088,8 +1119,12 @@ must be an algorithm accepting an exception.
     </ol>

Would've commented further up, but there's a call to incrementally-read loop (line 1113) that doesn't pass the timing info struct along, and probably should

> @@ -1055,6 +1083,9 @@ must be an algorithm accepting an exception.
    <dd>
     <ol>
      <li><p>Let <var>continueAlgorithm</var> be null.
+     <li><p>If <var>timingInfo</var> is not null, and <var>timingInfo</var>'s
+     <a for="fetch timing info">response start time</a> is not zero, set <var>timingInfo</var>'s

Should we set the response start time when it *is* zero, rather than when it's not?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1185#pullrequestreview-602696387