- From: Anne van Kesteren <notifications@github.com>
- Date: Wed, 03 Mar 2021 00:21:26 -0800
- To: whatwg/xhr <xhr@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 3 March 2021 08:21:38 UTC
@annevk commented on this pull request. > <ol> - <li><p>If <var>xhr</var>'s <a>synchronous flag</a> is set, then set <var>xhr</var>'s - <a for=XMLHttpRequest>response</a> to <var>response</var>. - - <li><p><a>Handle errors</a> for <var>xhr</var> and <var>response</var>. + <li><p><a>Handle errors</a> for <var>xhr</var>. You're right, handle errors should keep the is network error conditional at the end and instead we should set response to a network error before invoking it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/xhr/pull/315#discussion_r586204528
Received on Wednesday, 3 March 2021 08:21:38 UTC