Re: [whatwg/fetch] Integrate with Fetch Metadata. (#993)

@annevk commented on this pull request.

Thanks for getting around to updating this. The plan looks good to me, I only have nits.

> @@ -1661,6 +1662,10 @@ Unless stated otherwise, it is unset.
 
 <p class="note no-backref">This flag is for exclusive use by HTML's navigate algorithm. [[!HTML]]
 
+<p>A <a for=/>request</a> has an associated
+<dfn export for=request id=concept-request-user-activation-flag>user-activation flag</dfn>. Unless
+stated otherwise, it is unset.

Let's change this into a boolean, similar to keepalive. I'd like to avoid adding flags and slowly convert existing flags to booleans. (I'm happy to help with this for the Fetch and HTML PRs if needed, but would prefer if someone else did it for Fetch Metadata.)

I think we should also add a note that this is for exclusive usage by HTML's navigate algorithm. At least for now?

> @@ -4203,6 +4208,9 @@ steps. They return a <a for=/>response</a>.
 
    <li><p><a>Append a request `<code>Origin</code>` header</a> for <var>httpRequest</var>.
 
+   <li><p><a abstract-op lt="set the Fetch metadata headers for a request">Set the Fetch metadata
+   headers for <var>request</var></a>. [[!FETCH-METADATA]]

_httpRequest_, right?

> @@ -4203,6 +4208,9 @@ steps. They return a <a for=/>response</a>.
 
    <li><p><a>Append a request `<code>Origin</code>` header</a> for <var>httpRequest</var>.
 
+   <li><p><a abstract-op lt="set the Fetch metadata headers for a request">Set the Fetch metadata
+   headers for <var>request</var></a>. [[!FETCH-METADATA]]

And ideally we would use "append" here as we do elsewhere since there should be nothing to override.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/993#pullrequestreview-601799405