- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 30 Jun 2021 10:18:16 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 30 June 2021 17:18:28 UTC
@domenic commented on this pull request. > 1. Perform [=!=] [$CreateDataProperty$](|handler|, "<code>preventExtensions</code>", |preventExtensions|). - 1. Let |set| be [=!=] [$CreateBuiltinFunction$](the steps from [[#es-observable-array-set]], « », |realm|). + 1. Let |set| be [=!=] [$CreateBuiltinFunction$](the steps from [[#es-observable-array-set]], the number of non-optional parameters from [[#es-observable-array-set]], "<code>set</code>", « », |realm|). 1. Perform [=!=] [$CreateDataProperty$](|handler|, "<code>set</code>", |set|). Hmm. I kind of like the way the PR currently does it for lengths, in that it doesn't require syncing the length column with the steps like your proposal would. Since the proxy handlers are an unobservable internal implementation detail anyway, I think we could just set the length to 0 and the name to "" for all of them, with a `<p class="note">` explaining? The table/loop format would improve the section in general, but I'm not sure it needs to be done in this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/914#discussion_r661670369
Received on Wednesday, 30 June 2021 17:18:28 UTC