- From: ninevra <notifications@github.com>
- Date: Fri, 25 Jun 2021 10:15:13 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 25 June 2021 17:15:34 UTC
The [spec](https://streams.spec.whatwg.org/#default-reader-class-definition) says this should be `{value: any, done: boolean}`, not `{chunk: any, done: boolean}`. The code generated by this webidl file is never run, because `ReadableStreamDefaultReadResult`s are only ever used wrapped in `Promise`s, which `webidl2js` currently doesn't unwrap. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/1138 -- Commit Summary -- * Fix ReadableStreamDefaultReadResult.webidl -- File Changes -- M reference-implementation/lib/ReadableStreamDefaultReadResult.webidl (2) -- Patch Links -- https://github.com/whatwg/streams/pull/1138.patch https://github.com/whatwg/streams/pull/1138.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1138
Received on Friday, 25 June 2021 17:15:34 UTC