Re: [whatwg/fetch] Adapt to embedder policy being in policy container (#1258)

@annevk commented on this pull request.



>  
 <ol>
  <li><p>Set <var>forNavigation</var> to false if it is not given.
 
- <li><p>Let <var>embedderPolicy</var> be <var>settingsObject</var>'s
- <a for="environment settings object">embedder policy</a>.

I see, I agree with that. It's unfortunate we need to keep the _settingsObject_ argument for communication purposes as it creates the opportunity for subtle mistakes to creep in. Perhaps if we keep this as-is we should at least add a note here that this is fine because embedder policy cannot change over time.

Anyone else have an opinion one way or another?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1258#discussion_r656805780

Received on Wednesday, 23 June 2021 06:47:53 UTC