- From: ExE Boss <notifications@github.com>
- Date: Mon, 21 Jun 2021 07:06:40 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 21 June 2021 14:07:33 UTC
@ExE-Boss commented on this pull request.
> @@ -12748,7 +12722,7 @@ The \[[Prototype]] [=internal slot=] of an [=asynchronous iterator prototype obj
1. If |ongoingPromise| is not null, then:
1. Let |afterOngoingPromiseCapability| be [=!=] [$NewPromiseCapability$]({{%Promise%}}).
- 1. Let |onSettled| be [=!=] [$CreateBuiltinFunction$](|nextSteps|, « »).
+ 1. Let |onSettled| be [=!=] [$CreateBuiltinFunction$](|nextSteps|, 0, "", « »).
> Are these observable?
I don’t think so, since it’s passed directly to [PerformPromiseThen](https://tc39.es/ecma262/#sec-performpromisethen), rather than going through <code>[%Promise.prototype%.then](https://tc39.es/ecma262/#sec-promise.prototype.then)</code>.
----
> Should the length be one like the others?
Well, <var>nextSteps</var> doesn’t take any parameters, so it’s similar to:
```js
const nextSteps = () => { ... };
```
Which has a length of `0`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/914#discussion_r655407826
Received on Monday, 21 June 2021 14:07:33 UTC