- From: Kagami Sascha Rosylight <notifications@github.com>
- Date: Thu, 10 Jun 2021 07:50:15 -0700
- To: w3c/selection-api <selection-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/selection-api/pull/136@github.com>
It matches the actual browser behavior.
Closes #125
The following tasks have been completed:
* [x] Modified Web platform tests (link to pull request): Already written as such https://github.com/web-platform-tests/wpt/blob/7b0ebaccc62b566a1965396e5be7bb2bc06f841f/selection/selectAllChildren.html#L53
Implementation commitment:
* [x] WebKit https://webkit-search.igalia.com/webkit/rev/267a25a31211b30330b892dafd40b1ecf8c69505/Source/WebCore/page/DOMSelection.cpp#443
* [x] Chromium https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/editing/dom_selection.cc;l=755?q=Selection::SelectAllChildren
* [x] Gecko https://searchfox.org/mozilla-central/rev/2c991232499e826e46f9d976eb653817340ba389/dom/base/Selection.cpp#2675
<!--
This comment and the below content is programatically generated.
You may add a comma-separated list of anchors you'd like a
direct link to below (e.g. #idl-serializers, #idl-sequence):
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/selection-api/pull/136.html" title="Last updated on Jun 10, 2021, 2:50 PM UTC (fc5830a)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/selection-api/136/b3e79ef...fc5830a.html" title="Last updated on Jun 10, 2021, 2:50 PM UTC (fc5830a)">Diff</a>
You can view, comment on, or merge this pull request online at:
https://github.com/w3c/selection-api/pull/136
-- Commit Summary --
* Fix selectAllChildren to use child count
-- File Changes --
M index.html (4)
-- Patch Links --
https://github.com/w3c/selection-api/pull/136.patch
https://github.com/w3c/selection-api/pull/136.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/selection-api/pull/136
Received on Thursday, 10 June 2021 14:51:40 UTC