- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 07 Jun 2021 10:28:08 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 7 June 2021 17:29:09 UTC
@domenic commented on this pull request. > @@ -4421,7 +4441,8 @@ the {{WritableStream}}'s public API. 1. [=Reject=] |stream|.[=WritableStream/[[inFlightCloseRequest]]=] with |error|. 1. Set |stream|.[=WritableStream/[[inFlightCloseRequest]]=] to undefined. 1. Assert: |stream|.[=WritableStream/[[state]]=] is "`writable`" or "`erroring`". - 1. If |stream|.[=WritableStream/[[pendingAbortRequest]]=] is not undefined, + 1. If |stream|.[=WritableStream/[[pendingAbortRequest]]=] is not undefined and |error| is not an OK, so in that case, it seems like you can avoid the problem by not rejecting the promise returned by close when the reset operation is done. Returning a rejected promise from close indicates the closing failed, which it doesn't sound like is accurate in that case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1132#discussion_r646799579
Received on Monday, 7 June 2021 17:29:09 UTC