- From: Mattias Buelens <notifications@github.com>
- Date: Mon, 07 Jun 2021 03:27:59 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 7 June 2021 10:28:40 UTC
@MattiasBuelens commented on this pull request. > + 1. If |otherCanceled| is false and + |otherBranch|.[=ReadableStream/[[controller]]=].[=ReadableByteStreamController/[[pendingPullIntos]]=] + is not [=list/is empty|empty=], perform ! + [$ReadableByteStreamControllerRespond$](|otherBranch|.[=ReadableStream/[[controller]]=], 0). + 1. If |byobCanceled| is false or |otherCanceled| is false, [=resolve=] |cancelPromise| with undefined. + + : [=read-into request/error steps=] + :: + 1. Set |reading| to false. + 1. Perform ! [$ReadableStreamBYOBReaderRead$](|reader|, |view|, |readIntoRequest|). + 1. Let |pull1Algorithm| be the following steps: + 1. If |reading| is true, return [=a promise resolved with=] undefined. + 1. Set |reading| to true. + 1. Let |byobRequest| be ! [$ReadableByteStreamControllerGetBYOBRequest$](|branch1|.[=ReadableStream/[[controller]]=]). + 1. If |byobRequest| is null, + 1. Perform |pullWithDefaultReader|. Right, [he did](https://github.com/whatwg/streams/pull/1114#discussion_r645566297), but I only fixed one instance. I'll go through the whole thing again. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1114#discussion_r646463100
Received on Monday, 7 June 2021 10:28:40 UTC