- From: Anne van Kesteren <notifications@github.com>
- Date: Mon, 26 Jul 2021 06:24:26 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 26 July 2021 13:24:38 UTC
@annevk commented on this pull request. Missed a nit, but looks good to me apart from that. I guess the main thing here is getting implementer interest and tests, probably best managed as part of the HTML change. > @@ -7533,7 +7533,7 @@ therefore not shareable, a WebSocket connection is very close to identical to an <h3 id=websocket-opening-handshake>Opening handshake</h3> <p>To <dfn id=concept-websocket-establish>establish a WebSocket connection</dfn>, given a -<var>url</var>, <var>protocols</var>, and <var>client</var>, run these steps: +<var>url</var>, <var>protocols</var>, <var>credentialsMode</var>, and <var>client</var>, run these steps: Nit: exceeds a 100 columns. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1273#pullrequestreview-714837870
Received on Monday, 26 July 2021 13:24:38 UTC