Re: [whatwg/streams] Add ReadableStreamBYOBReader.readFully() (#1145)

@MattiasBuelens commented on this pull request.

I suppose we should update (or remove) [the `readInto()` example](https://streams.spec.whatwg.org/commit-snapshots/109f1d4f9fba4eed42238f8de5b9201b8769cd8c/#example-manual-read-bytes) too? Since that can be now replaced with a single `readFully()` call.

> +: <dfn for="pull-into descriptor">read fully</dfn>
+:: A boolean flag indicating whether this is a {{ReadableStreamBYOBReader/readFully()}} request.

Nit-pick: do we prefer enums over boolean flags? Something like "request type" which can be "default read", "byob read" or "byob read fully"?

Or perhaps we can combine this with "reader type"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1145#pullrequestreview-711756711