Re: [w3c/manifest] Add id member to manifest (#988)

@aarongustafson approved this pull request.

Just some minor suggestions.

> +      <section>
+        <h3>
+          `id` member
+        </h3>
+        <p>
+          The [=manifest's=] <code><dfn data-export="" data-dfn-for=
+          "manifest">id</dfn></code> member is a <a>string</a> that
+          represents the <dfn>id</dfn> for the application.
+        </p>
+        <p>The |id| is used  by user agents uniquely identify the application
+          globally. When |id| is changed, it's recognized as a new app and
+          can be installed separately. When id is not changed, it can be used
+          to find installed application to perform manifest update.
+        </p>
+        <p>
+          The |id| can also be used by third party entities such as PWA stores

"implementors" is a safe general term.

> +          globally. When |id| is changed, it's recognized as a new app and
+          can be installed separately. When id is not changed, it can be used
+          to find installed application to perform manifest update.
+        </p>
+        <p>
+          The |id| can also be used by third party entities such as PWA stores
+          to uniquely identify and reference web apps
+        </p>
+        <p>
+          To <dfn>process the `id` member</dfn>, given [=object=]
+          |json:JSON|, [=ordered map=] |manifest:ordered map|.:
+        </p>
+        <ol class="algorithm">
+          <li>If the type of |json|["id"] is not [=string=], return.
+          </li>
+          <li>Let |id:URL| be the result of [=URL Parser|parsing=]

FWIW, I like the idea of a table of examples showing how the items would be combined either with or without a defined `id`/`identity`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/988#pullrequestreview-710888446

Received on Tuesday, 20 July 2021 17:33:00 UTC