- From: Mattias Buelens <notifications@github.com>
- Date: Mon, 12 Jul 2021 16:35:44 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/1130/review/704624825@github.com>
@MattiasBuelens requested changes on this pull request.
That seems reasonable. In that case, we need to do something similar as in the read request close steps of [`ReadableByteStreamTee`](https://streams.spec.whatwg.org/commit-snapshots/cada8129edcc4803b2878a7a3f5e1d8325dc0c23/#abstract-opdef-readablebytestreamtee). (See suggestion below.)
> + 1. If |stream|.[=ReadableStream/[[controller]]=] [=implements=] {{ReadableByteStreamController}},
+ then perform !
+ [$ReadableByteStreamControllerClose$](|stream|.[=ReadableStream/[[controller]]=]).
```suggestion
1. If |stream|.[=ReadableStream/[[controller]]=] [=implements=] {{ReadableByteStreamController}},
1. Perform !
[$ReadableByteStreamControllerClose$](|stream|.[=ReadableStream/[[controller]]=]).
1. If |stream|.[=ReadableStream/[[controller]]=].[=ReadableByteStreamController/[[pendingPullIntos]]=]
is not [=list/is empty|empty=], perform !
[$ReadableByteStreamControllerRespond$](|stream|.[=ReadableStream/[[controller]]=], 0).
<p class="note">The caller has to make sure not to write into the
[=ReadableStream/current BYOB request view=] or transfer it to a different realm before
closing the stream.
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1130#pullrequestreview-704624825
Received on Monday, 12 July 2021 23:35:56 UTC