- From: Timothy Gu <notifications@github.com>
- Date: Thu, 08 Jul 2021 15:58:49 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 8 July 2021 22:59:39 UTC
@TimothyGu commented on this pull request. > + + <li> + <p>If the last <a for=list>item</a> in <var>parts</var> is the empty string, then: + + <ol> + <li><p>If <var>parts</var>'s <a for=list>size</a> is 1, return false. + + <li>Otherwise, <a for=list>remove</a> the last <a for=list>item</a> from <var>parts</var>. + </ol> + + <li><p>Let <var>last</var> be the last <a for=list>item</a> from <var>parts</var>. + + <li>If parsing <var>last</var> as an <a lt="IPv4 number parser">IPv4 number</a> does not + return failure, return true. + + <li><p>If <var>last</var> is non-empty and contains only <a>ASCII digits</a>, return true. Maybe mention in a note we could get here for _last_ = "`09`", because IPv4 number parser would treat it as octal? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/619#pullrequestreview-702561609
Received on Thursday, 8 July 2021 22:59:39 UTC