- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 29 Jan 2021 11:22:20 -0800
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 29 January 2021 19:22:36 UTC
@domenic commented on this pull request. These should be `<dfn for="algorithm name">` so that cross-linking from callers works. I think updating all the callers is a long project, but it'd be good to do the groundwork here ahead of time so that we can update over time. > @@ -1626,8 +1623,8 @@ different document encoding. Using the <a>UTF-8</a> encoding everywhere solves t <h3 id=url-parsing>URL parsing</h3> <p>The <dfn export id=concept-url-parser lt="URL parser">URL parser</dfn> takes a string -<var>input</var>, with an optional <a>base URL</a> <var>base</var> and an optional -<a for=/>encoding</a> <var>encoding override</var>, and then runs these steps: +<var>input</var>, with an optional <a>base URL</a> <var>base</var> (default null) and an optional optional base URL-or-null? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/575#pullrequestreview-579550572
Received on Friday, 29 January 2021 19:22:36 UTC