- From: Lea Verou <notifications@github.com>
- Date: Thu, 28 Jan 2021 08:32:14 -0800
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 28 January 2021 16:32:27 UTC
@kenchris, @torgo, @rhiaro and I discussed this in our VF2F breakout today. Here is our feedback: - It may be good to prefer a dictionary over adding a positional primitive argument, in line with [Principle 5.3](https://w3ctag.github.io/design-principles/#prefer-dict-to-bool). While some of the reasoning behind this principle doesn't apply here (since this callback is only called by the UA), a dictionary would allow communicating more information to the callback in the future, without introducing a long list of positional arguments that need to be backfilled. - We wondered if it would be more in line with your listed goals to report the *number* of dropped entries, so appropriate optimizations can be made. E.g. the need for buffer adjustments is higher when there are thousands of dropped entries compared to a couple. We also wondered if it would assist in reducing the number of dropped entries if developers could set the buffer size via an `observe()` parameter. - A little of the discussion revolved around naming. If this changes to communicate number of dropped entries, it could change to e.g. `droppedEntries`. The word `truncated` could also be useful in coming up with alternative composite names. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/547#issuecomment-769208072
Received on Thursday, 28 January 2021 16:32:27 UTC