- From: Jake Archibald <notifications@github.com>
- Date: Mon, 18 Jan 2021 07:28:18 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1444/review/570590280@github.com>
@jakearchibald commented on this pull request.
> @@ -2873,8 +2879,19 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
1. Set |workerGlobalScope|'s [=ServiceWorkerGlobalScope/force bypass cache for import scripts flag=] if |forceBypassCache| is true.
1. Create a new {{WorkerLocation}} object and associate it with |workerGlobalScope|.
1. If |serviceWorker| is an <a>active worker</a>, and there are any <a>tasks</a> queued in |serviceWorker|'s <a>containing service worker registration</a>'s [=service worker registration/task queues=], <a lt="queue a task">queue</a> them to |serviceWorker|'s <a>event loop</a>'s [=/task queues=] in the same order using their original <a>task sources</a>.
- 1. Let |evaluationStatus| be the result of <a lt="run a classic script">running the classic script</a> |script| if |script| is a <a>classic script</a>, otherwise, the result of <a lt="run a module script">running the module script</a> |script| if |script| is a [=module script=].
- 1. If |evaluationStatus|.\[[Value]] is empty, this means the script was not evaluated. Set |startFailed| to true and abort these steps.
+ 1. Let |evaluationStatus| be null.
+ 1. If |script| is a <a>classic script</a>, then:
+ 1. Set |evaluationStatus| to the result of <a lt="run a classic script">running the classic script</a> |script|.
+ 1. If |evaluationStatus|.\[[Value]] is empty, this means the script was not evaluated. Set |startFailed| to true and abort these steps.
+ 1. Otherwise, if |script| is a [=module script=], then:
+ 1. Let |evaluationPromise| be the result of <a lt="run a module script">running the module script</a> |script|, with report errors set to false.
+ 1. Assert: |evaluationPromise|.\[[PromiseState]] is not "pending".
+ 1. If |evaluationPromise|.\[[PromiseState]] is "rejected":
+ 1. Set |startFailed| to true and abort these steps.
+
+ Note: This is intended to maintain compatibilty with failing synchronous modules before the introduction of asynchronous modules.
+ 1. Otherwise:
+ 1. Set |evaluationStatus| to [$NormalCompletion$](undefined).
Ignore me, I misinterpreted this as a markdown link.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1444#discussion_r559643287
Received on Monday, 18 January 2021 15:28:32 UTC