- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 08 Jan 2021 14:44:24 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 8 January 2021 22:44:36 UTC
@domenic commented on this pull request. > @@ -1456,6 +1456,6 @@ function ReadableStreamFromIterable(asyncIterable) { return promiseResolvedWith(returnResult); } - stream = CreateReadableStream(startAlgorithm, pullAlgorithm, cancelAlgorithm); + stream = CreateReadableStream(startAlgorithm, pullAlgorithm, cancelAlgorithm, 0); Hmm. I have a slight bias toward keeping our default, since it must have been picked for a reason :). In particular, I believe our historical intention has been that by default readable streams should try to keep something in their internal queue, whether that something is derived from a `controller.enqueue()` call in `start()`, or one in `pull()`. I think that same logic applies to deriving it from an async iterator. Transform streams are a bit different, as we want introducing them to be more of a no-op and not cause a bunch of chunks to sit in intermediate transform-stream queues, unless explicitly requested. On the other hand, you could view `ReadableStream.from()` as a sort of transform, such that the same no-op logic should apply. Hmm. @ricea, any thoughts? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1083#discussion_r554232720
Received on Friday, 8 January 2021 22:44:36 UTC