- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 23 Feb 2021 10:28:12 -0800
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 23 February 2021 18:28:26 UTC
Editorially LGTM and matches the tests and jsdom/whatwg-url implementation. In terms of interop and implementation alignment, of the three tests added in https://github.com/web-platform-tests/wpt/pull/27720: - Safari passes test 1 and 3, but not test 2 - Firefox and Chrome pass test 1, but not test 2 or test 3 - jsdom/whatwg-url, and thus the current spec, passes tests 1 and 2 but not test 3 Should we consider changing the spec for test 2? I don't have a strong intuition on the model here though so maybe there's a reason that would be bad. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/582#issuecomment-784415580
Received on Tuesday, 23 February 2021 18:28:26 UTC