- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 18 Feb 2021 01:00:01 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 18 February 2021 09:00:14 UTC
@annevk commented on this pull request.
> @@ -3835,6 +3836,13 @@ these steps:
</ul>
<p>then return a <a>network error</a>.
+
+ <li>
+ <p>Set <var>actualResponse</var>'s <a for=response>URL</a>'s <a for=url>fragment</a> to
+ <var>request</var>'s <a for=request>current URL</a>'s <a for=url>fragment</a>.
+
+ <p class=note>There is currently no mechanism for the service worker to control
+ <var>actualResponse</var>'s <a for=response>URL</a>'s <a for=url>fragment</a>.
Thanks @davidben, you're right, this isn't great. I think your model is better but it would change `fetchEvent.request.url`. Is Chrome willing to experiment with that? I suppose synthetic responses would always end up with the fragment of the request from the document, which seems about right, but the current wording indeed isn't adequate.
Perhaps I should split out the service worker change into its own issue and pull request (it already has its own tests) as that clearly warrants some further consideration.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/696#discussion_r578240428
Received on Thursday, 18 February 2021 09:00:14 UTC