Re: [w3c/ServiceWorker] Have "Handle Fetch" return error when request's streaming body is unusable (#1563)

@MattiasBuelens requested changes on this pull request.



> +              1. If |response| is null, |request|'s [=request/body=] is not null, and |request|'s [=request/body=]'s [=Body/source=] is null, then:
+           1. If |request|'s [=request/body=] is [=Body/unusable=], set |handleFetchFailed| to true.
+    2. Else, [=ReadableStream/cancel=] |request|'s [=request/body=] with undefined.

The steps are numbered incorrectly, see screenshot:
![image](https://user-images.githubusercontent.com/649348/108218927-78deba00-7135-11eb-85d4-677a75a7fca2.png)

I think it's because the indentation is inconsistent (tabs mixed with spaces). Also, all numbered steps should be prefixed with `1.`, we shouldn't have a `2.` in there.
```suggestion
              1. If |response| is null, |request|'s [=request/body=] is not null, and |request|'s [=request/body=]'s [=Body/source=] is null, then:
                  1. If |request|'s [=request/body=] is [=Body/unusable=], set |handleFetchFailed| to true.
                  1. Else, [=ReadableStream/cancel=] |request|'s [=request/body=] with undefined.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1563#pullrequestreview-592257829

Received on Wednesday, 17 February 2021 14:39:07 UTC