Re: [whatwg/fetch] Add more parameters to "obtain a connection" (#1171)

@annevk commented on this pull request.

This looks reasonable to me modulo nits. Thanks for working on this!

> @@ -2127,12 +2133,24 @@ identified by a <b>key</b> (a <a>network partition key</a>), an <b>origin</b> (a
 <a for=/>origin</a>), and <b>credentials</b> (a boolean).
 
 <p>To <dfn export id=concept-connection-obtain>obtain a connection</dfn>, given a <var>key</var>,
-<var>origin</var>, and <var>credentials</var>, run these steps:
+<var>origin</var>, <var>credentials</var>, optionally <var>forHTTP3</var> (a boolean, false by
+default), and optionally <var>sharable</var> (a boolean, true by default), run these steps:

Beware that this will conflict with @yoichio's work in #1141. With 3 optional parameters, we probably need to make them non-positional. See https://infra.spec.whatwg.org/#algorithm-params for syntax (the fetch algorithm has them as well now). Note that parameters that default to true are not allowed.

>  
 <ol>
- <li><p>If the user agent's <a>connection pool</a> contains a <a>connection</a> whose <b>key</b> is
- <var>key</var>, <b>origin</b> is <var>origin</var>, and <b>credentials</b> is
- <var>credentials</var>, then return that <a>connection</a>.
+ <li>
+  <p>If <var>sharable</var> is true, then:
+
+  <ol>
+   <li><p>Let <var>connections</var> be a set of <a>connection</a>s in the user agent's

Please keep the s inside the link.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1171#pullrequestreview-592094889