- From: Jeffrey Yasskin <notifications@github.com>
- Date: Tue, 16 Feb 2021 16:13:47 -0800
- To: w3c/permissions <permissions@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/permissions/pull/229/review/591723481@github.com>
@jyasskin approved this pull request.
If these are the only 2 permissions that have actually been defined outside the spec, I guess it's ok to lose that functionality, with the linking changes below. Once this goes in, we should update the other two specs to avoid re-defining the enum values.
> @@ -924,6 +922,26 @@ spec:infra; type:dfn; text:list
[[web-background-sync]].
</p>
</section>
+ <section>
+ <h3 id="bluetooth">
+ Bluetooth
+ </h3>
+ <p>
+ The <dfn for="PermissionName" enum-value>"bluetooth"</dfn>
This is going to create a duplicate definition of `PermissionName/"bluetooth"` between here and https://webbluetoothcg.github.io/web-bluetooth/#dom-permissionname-bluetooth.
> + <section>
+ <h3 id="bluetooth">
+ Bluetooth
+ </h3>
+ <p>
+ The <dfn for="PermissionName" enum-value>"bluetooth"</dfn>
+ permission is the permission associated with the usage of
+ [[web-bluetooth]].
+ </p>
+ </section>
+ <section>
+ <h3 id="persistent-storage">
+ Persistent Storage
+ </h3>
+ <p>
+ The <dfn for="PermissionName" enum-value>"persistent-storage"</dfn>
This is going to create a duplicate definition of `PermissionName/"persistent-storage"` between here and https://storage.spec.whatwg.org/#dom-permissionname-persistent-storage, and lose the direct link to the right part of the Storage spec. We could move the direct link to the use of `[[storage]]` below.
> + permission is the permission associated with the usage of
+ [[storage]].
```suggestion
permission ([[storage#persistence]]) is the permission associated with the
usage of the `"persistent"` storage bucket <a spec="storage" for="local
storage bucket">mode</a>.
```
> + permission is the permission associated with the usage of
+ [[web-bluetooth]].
```suggestion
permission ([[web-bluetooth#permission-api-integration]]) controls usage
of [[web-bluetooth]].
```
```suggestion
permission ([[web-bluetooth#permission-api-integration]]) is the
permission associated with the usage of [[web-bluetooth]].
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/229#pullrequestreview-591723481
Received on Wednesday, 17 February 2021 00:13:59 UTC